feat: migrate to Angular 12 #246
Conversation
|
Can you merge this PR? |
|
@smnbbrv Can you merge/release this? Or maybe can you give us a contact from someone who could do that for this repository? |
|
Can we merge this branch. I think many people who want to use sortablejs would need this. If it's unsupported maybe a new maintainer could be found? |
|
I'm very Sorry for tagging you, but could you please merge this ? This is here already for 4 months |
I'm sorry. I just got enrolled to the team half a month ago just for the react sortable binding project. |
|
No problem, could you maybe ping someone from the team that can merge this ? Because if they enrolled you, then it means that atleast someone is active :) Thank you @andresin87 |
|
@Anikethana I believe that we should add "compilationMode": "partial" in the libs prod tsconfig https://angular.io/guide/creating-libraries#ensuring-library-version-compatibility |
| @@ -1,5 +1,8 @@ | |||
| { | |||
| "$schema": "./node_modules/@angular/cli/lib/config/schema.json", | |||
| "cli": { | |||
| "analytics": "97b059d8-f275-47b1-ad17-9665c85827b3" | |||
There was a problem hiding this comment.
What is this? Better remove I would say.
|
Also need to update peerDependencies on package.json |
Can you also update package.json file |
|
Is this project dead? |
|
seems to be dead, i wouldn't use it if you have other options |
|
Unfortunately, I can't find a good alternative. Dragula is also dead for quite some time now. |
|
This are some alternatives that are maintained. The downside of the first and second is that they aren't as conveniently wrapped for Angular. But it recommend going down this path rather then to use the seemingly unmaintained sortablejs https://github.com/Shopify/draggable Also simple stuff can be done using the HTML drag API. It's not too shabby. I created my own directives for a folder like, multi object dnd |
|
SortableJS is one of the only frameworks that works nicely together with multiple columns and rows (grid). Most others, like cdk, don't have nice animations or don't work at all in a grid display. Edit: seems draggable is not very well maintained either as mentioned on their github page. |
|
You are right about draggable, but at the moment is maintained and they search for maintainers, so i'd say it is a valid option. I mean you always can fork ngx-sortableJS it and bring it up to Angular 14 (or whatever version u need) |
|
@smnbbrv |
Used ng upgrade to update