Messages appear only in proper chatrooms #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minghz
reviewed
Oct 25, 2017
| return $('#messages').append(this.renderMessage(data)); | ||
| }, | ||
| chatroom_id: function(data) { |
There was a problem hiding this comment.
Don't think we need this chatroom_id function?
There was a problem hiding this comment.
I wrote this code a long time ago but I believe it's needed to identify the chatroom.
TImPDaley
approved these changes
Feb 28, 2018
NaokiIshimura
added a commit
to NaokiIshimura/action-cable-example
that referenced
this pull request
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of having a message appear in all chatrooms. Created a different name for each stream based on the chatroom's id which is inside of a hidden field in the message partial. If you like this solution, please follow me or star some of my projects! Thanks!