Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVS-1731 Remove ISecondaryIssueHashUpdater & SQService.GetSourceCodeAsync #5927

Merged
merged 1 commit into from
Dec 27, 2024
+10 −600
Merged

SLVS-1731 Remove ISecondaryIssueHashUpdater & SQService.GetSourceCodeAsync #5927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 0 additions & 103 deletions src/SonarQube.Client.Tests/CallRealServerTestHarness.cs
View file
Open in desktop

This file was deleted.

168 changes: 0 additions & 168 deletions src/SonarQube.Client.Tests/Helpers/SecondaryLocationHashUpdaterTests.cs
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions src/SonarQube.Client.Tests/Requests/DefaultConfiguration_Configure_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public void ConfigureSonarQube_Writes_Debug_Messages()
"Registered SonarQube.Client.Api.V2_10.GetVersionRequest for 2.1",
"Registered SonarQube.Client.Api.V2_60.GetPropertiesRequest for 2.6",
"Registered SonarQube.Client.Api.V3_30.ValidateCredentialsRequest for 3.3",
"Registered SonarQube.Client.Api.V5_00.GetSourceCodeRequest for 5.0",
"Registered SonarQube.Client.Api.V5_10.GetIssuesRequest for 5.1",
"Registered SonarQube.Client.Api.V5_10.GetLanguagesRequest for 5.1",
"Registered SonarQube.Client.Api.V5_20.GetQualityProfileChangeLogRequest for 5.2",
Expand Down Expand Up @@ -88,7 +87,6 @@ public void ConfigureSonarCloud_Writes_Debug_Messages()
{
"Registered SonarQube.Client.Api.V2_10.GetVersionRequest",
"Registered SonarQube.Client.Api.V3_30.ValidateCredentialsRequest",
"Registered SonarQube.Client.Api.V5_00.GetSourceCodeRequest",
"Registered SonarQube.Client.Api.V5_10.GetLanguagesRequest",
"Registered SonarQube.Client.Api.V5_40.GetModulesRequest",
"Registered SonarQube.Client.Api.V10_2.GetRulesWithCCTRequest",
Expand Down Expand Up @@ -141,7 +139,6 @@ public void ConfigureSonarQube_CheckAllRequestsImplemented()
testSubject.Create<IGetRulesRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<IGetVersionRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<IValidateCredentialsRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<IGetSourceCodeRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<IGetProjectBranchesRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<IGetExclusionsRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<IGetSonarLintEventStream>(serverInfo).Should().NotBeNull();
Expand Down Expand Up @@ -172,7 +169,6 @@ public void ConfigureSonarCloud_CheckAllRequestsImplemented()
testSubject.Create<IGetRulesRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<IGetVersionRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<IValidateCredentialsRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<IGetSourceCodeRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<IGetProjectBranchesRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<IGetExclusionsRequest>(serverInfo).Should().NotBeNull();
testSubject.Create<ITransitionIssueRequest>(serverInfo).Should().NotBeNull();
Expand Down
6 changes: 3 additions & 3 deletions src/SonarQube.Client.Tests/SonarQubeService_GetProjectDashboardUrl_Disconnect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,13 @@ public async Task GetProjectDashboardUrl_DisconnectedInTheMiddle_NoException()

protected internal override SonarQubeService CreateTestSubject()
{
return new DisconnectingService(messageHandler.Object, UserAgent, logger, requestFactorySelector, secondaryIssueHashUpdater.Object);
return new DisconnectingService(messageHandler.Object, UserAgent, logger, requestFactorySelector);
}

internal class DisconnectingService : SonarQubeService
{
internal DisconnectingService(HttpMessageHandler messageHandler, string userAgent, ILogger logger, IRequestFactorySelector requestFactorySelector, ISecondaryIssueHashUpdater secondaryIssueHashUpdater)
: base(messageHandler, userAgent, logger, requestFactorySelector, secondaryIssueHashUpdater, null)
internal DisconnectingService(HttpMessageHandler messageHandler, string userAgent, ILogger logger, IRequestFactorySelector requestFactorySelector)
: base(messageHandler, userAgent, logger, requestFactorySelector, null)
{
}

Expand Down
Loading
Loading