Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVS-1691 Remove unused SQ.Client GetRules requests and properties #5926

Merged
merged 3 commits into from
Dec 27, 2024
Merged

SLVS-1691 Remove unused SQ.Client GetRules requests and properties #5926

merged 3 commits into from
Dec 27, 2024

Conversation

georgii-borovinskikh-sonarsource
Copy link
Contributor

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource commented Dec 24, 2024 •
edited by jira bot
Loading

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource changed the title SLVS-1691 Remove unused SQ GetRules requests and properties SLVS-1691 Remove unused SQ.Client GetRules requests and properties Dec 24, 2024
gabriela-trutan-sonarsource
gabriela-trutan-sonarsource approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still instances of

  • "htmlDesc" inside SonarQubeService_ExtensionMethods, SonarQubeService_GetRuleByKeyAsync.
  • DescriptionSections inside SonarLintConfigGeneratorTests, IRichRuleHelpXamlBuilder etc (please search for more instances)
  • all removed properties inside SonarLintConfigGeneratorTests.CreateRule

Please remove them

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource changed the base branch from master to feature/hardening-q4 December 27, 2024 14:20
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource merged commit 730a567 into feature/hardening-q4 Dec 27, 2024
3 checks passed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource deleted the gb/cleanup-sqc-rules branch December 27, 2024 14:34
gabriela-trutan-sonarsource pushed a commit that referenced this pull request Jan 8, 2025
@georgii-borovinskikh-sonarsource @gabriela-trutan-sonarsource
SLVS-1691 Remove unused SQ.Client GetRules requests and properties (#…
8b88e4a 
…5926)

[SLVS-1691](https://sonarsource.atlassian.net/browse/SLVS-1691)



[SLVS-1691]:
https://sonarsource.atlassian.net/browse/SLVS-1691?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
vnaskos-sonar pushed a commit that referenced this pull request Jan 10, 2025
@georgii-borovinskikh-sonarsource @vnaskos-sonar
SLVS-1691 Remove unused SQ.Client GetRules requests and properties (#…
12dd785 
…5926)

[SLVS-1691](https://sonarsource.atlassian.net/browse/SLVS-1691)



[SLVS-1691]:
https://sonarsource.atlassian.net/browse/SLVS-1691?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
vnaskos-sonar pushed a commit that referenced this pull request Jan 10, 2025
@georgii-borovinskikh-sonarsource @vnaskos-sonar
SLVS-1691 Remove unused SQ.Client GetRules requests and properties (#…
32094d5 
…5926)

[SLVS-1691](https://sonarsource.atlassian.net/browse/SLVS-1691)



[SLVS-1691]:
https://sonarsource.atlassian.net/browse/SLVS-1691?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
vnaskos-sonar pushed a commit that referenced this pull request Jan 10, 2025
@georgii-borovinskikh-sonarsource @vnaskos-sonar
SLVS-1691 Remove unused SQ.Client GetRules requests and properties (#…
de0c62a 
…5926)

[SLVS-1691](https://sonarsource.atlassian.net/browse/SLVS-1691)



[SLVS-1691]:
https://sonarsource.atlassian.net/browse/SLVS-1691?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource gabriela-trutan-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgii-borovinskikh-sonarsource @gabriela-trutan-sonarsource