SLVS-1732 Fix SSF-694 #5925
Merged
SLVS-1732 Fix SSF-694 #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource
approved these changes
Dec 24, 2024
|
|
||
| logger.Info($"Connected to {serverTypeDescription} '{serverInfo.Version}'."); | ||
| currentHttpClient = CreateHttpClient(connection.ServerUri, connection.Credentials, ShouldUseBearer(serverInfo)); |
There was a problem hiding this comment.
not sure if current prefix is really needed here
There was a problem hiding this comment.
I like current, because it's consistent with the currentServerInfo field.
Additionally, inside here, it will be easier to distinguish between the parameter and field
|
gabriela-trutan-sonarsource
merged commit abd00c5
into
feature/hardening-q4
3 checks passed
georgii-borovinskikh-sonarsource
pushed a commit
that referenced
this pull request
Dec 27, 2024
gabriela-trutan-sonarsource
added a commit
that referenced
this pull request
Jan 8, 2025
vnaskos-sonar
pushed a commit
that referenced
this pull request
Jan 10, 2025
vnaskos-sonar
pushed a commit
that referenced
this pull request
Jan 10, 2025
vnaskos-sonar
pushed a commit
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1732