SLVS-1722 Log extra properties of SLCore log events #5924
Conversation
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
| public string threadName; | ||
| public string loggerName; | ||
| // nullable | ||
| public string stackTrace; |
There was a problem hiding this comment.
We are missing the loggedAt property. Even if we don't use it for now, I think we should add it.
There was a problem hiding this comment.
added a comment
| @@ -34,25 +34,26 @@ public class LoggerListener : ILoggerListener | |||
| [ImportingConstructor] | |||
| public LoggerListener(ILogger logger) | |||
| { | |||
| this.logger = logger; | |||
| this.logger = logger.ForContext(SLCoreStrings.SLCoreName, SLCoreStrings.SLCoreInternalLogContext); | |||
There was a problem hiding this comment.
I think it's enough to add just one context that is a string of type "SlCore Logs". It would occupies less space than [SLCore > Logs].
There was a problem hiding this comment.
I will leave it as it was before, just SLCore
| break; | ||
| } | ||
|
|
||
| if (parameters.stackTrace != null) |
There was a problem hiding this comment.
Move the null check inside the LogVerbose method
There was a problem hiding this comment.
Don't really want to move this logic inside the logger. It's not really the logger's business IMO
georgii-borovinskikh-sonarsource
force-pushed
the
gb/log-context
branch
from
d01d7dd to
dc2b4c0
Compare
georgii-borovinskikh-sonarsource
force-pushed
the
gb/slcore-log-properties
branch
from
77eab71 to
201c413
Compare
georgii-borovinskikh-sonarsource
force-pushed
the
gb/slcore-log-properties
branch
from
201c413 to
ad18a41
Compare
|
georgii-borovinskikh-sonarsource
merged commit 7e16bea
into
feature/hardening-q4
SLVS-1722