SLVS-1491 Refactor: use ConnectedModeManager #5730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log. This has multiple advantages including better testability of code and the fact that the callers don't have to add references to all the services required to show the ManageBinding dialog,
…nnection to the server is shown.
…ntiate the ManageBindingDialog
hashicorp-vault-sonar-prod
bot
changed the title
gabriela-trutan-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
gabriela-trutan-sonarsource
changed the title
georgii-borovinskikh-sonarsource
approved these changes
Oct 7, 2024
| suggestSharedBindingGoldBar.When(x => x.Show(ServerType.SonarQube, Arg.Any<Action>())).Do(callInfo => | ||
| { | ||
| callInfo.Arg<Action>()(); | ||
| connectedModeManager.Received(1).ShowManageBindingDialog(true); |
There was a problem hiding this comment.
Not sure if it's a good idea to put assertions inside setup code. If you wanted to assert the order of calls, you can use Received.InOrder(...)
There was a problem hiding this comment.
I don't want to test the order, but I want to know what happens when the action is called. So, I really have to store the action and call it. I can refactor this to make it more explicit.
Base automatically changed from
gt/validate-fix-suggestion
to
feature/fix-suggestion
October 7, 2024 13:49
|
gabriela-trutan-sonarsource
merged commit 34b0d8a
into
feature/fix-suggestion
2 checks passed
gabriela-trutan-sonarsource
deleted the
gt/connected-mode-manager-usage
branch
vnaskos-sonar
pushed a commit
that referenced
this pull request
Oct 8, 2024
vnaskos-sonar
pushed a commit
that referenced
this pull request
Oct 9, 2024
vnaskos-sonar
pushed a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring: use ConnectedModeManager in the other places where we instantiate the ManageBindingDialog to make code better testable