SLVS-1400 Add migration mechanism to separate connections from bindings #5696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terraform-techuser
changed the title
vnaskos-sonar
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Just a small ordering comment, the other is up to your preference. 👍
| @@ -112,6 +114,15 @@ private async Task InitAsync() | |||
| logger?.WriteLine(Strings.Daemon_InitializationComplete); | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// This migration should be performed before initializing other services, independent if a solution or a folder is opened. | |||
There was a problem hiding this comment.
I feel that this comment should be above the method usage as it's a warning about the order.
| } | ||
|
|
||
| private async Task InitAsync() | ||
| { | ||
| try | ||
| { | ||
| await MigrateBindingsToServerConnectionsIfNeededAsync(); |
There was a problem hiding this comment.
This should be below the logger initialization and the initialization message.
[ThreadId 58] [Connection Migration] Start migrating connections from existing bindings
[ThreadId 58] [Connection Migration] The server connection with the id duncanp-sonar-test was not migrated as it already exists.
[ThreadId 58] Initializing the daemon package...
to
[ThreadId 58] Initializing the daemon package...
[ThreadId 58] [Connection Migration] Start migrating connections from existing bindings
[ThreadId 58] [Connection Migration] The server connection with the id duncanp-sonar-test was not migrated as it already exists.
|
gabriela-trutan-sonarsource
merged commit 6ce73f1
into
feature/new-connected-mode
2 checks passed
gabriela-trutan-sonarsource
deleted the
gt/binding-to-connection-migration
branch
vnaskos-sonar
pushed a commit
that referenced
this pull request
Sep 19, 2024
gabriela-trutan-sonarsource
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the migration and called it in the SonarLintDaemonPackage at the very beginning, because it should be performed as early as possible. This package is also called if solutions or folders are opened, or even none of them, which is desirable.
When the migration is performed for the first time, if you open a solution super fast, it might not actually be bound. But if you re-open the solution, then everything works as expected.
I did not find a workaround for this issue (even triggering the binding manually did not help, I guess because it was too early). But I don't think I should invest too much effort into this, as it will only happen once: when the migration is performed, after the first update.