SLVS-1369 Add checkServerTrusted rpc method implementation #5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
marked this pull request as ready for review
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
gabriela-trutan-sonarsource
approved these changes
Sep 5, 2024
| public bool ValidateChain(X509Certificate2 primaryCertificate, IEnumerable<X509Certificate2> additionalCertificates) | ||
| { | ||
| logger.LogVerbose($"[{nameof(CertificateChainValidator)}] Validating certificate: " + primaryCertificate); | ||
| var x509Chain = new X509Chain(); |
There was a problem hiding this comment.
The X509Chain implements IDisposable. Wrap code in a using statement
| public async Task CheckServerTrustedAsync_MultipleCertificates_ConvertsAndValidates(bool validationResult) | ||
| { | ||
| var primaryCertificateDto = new X509CertificateDto("some certificate"); | ||
| var additionalCertificateDto1 = new X509CertificateDto("some other certificate 1"); |
There was a problem hiding this comment.
Please extract the mocking of a certificate in a separate method and reuse the method in all unit tests. This will reduce the noise in this unit test and it will make it easier to understand.
|
georgii-borovinskikh-sonarsource
merged commit 36034e6
into
feature/hardening-sept-2024
2 checks passed
georgii-borovinskikh-sonarsource
deleted the
gb/slcore-certificate-check
branch
georgii-borovinskikh-sonarsource
added a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1369