Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in IDE: various bug fixes #5395

Conversation

georgii-borovinskikh-sonarsource
Copy link
Contributor

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource commented May 1, 2024

Fixes:

  • SolutionWorkspaceService & FolderWorkspaceService: change IEnumerable to ICollection in file listing to prevent delaying collection enumeration due to laziness
  • SolutionWorkspaceService: deduplicate files when listing solution items
  • SLCoreConstantsProvider: enable managing of the Open in IDE server by SLOOP
  • Add comment pointing to https://sonarsource.atlassian.net/browse/SLCORE-783 ticket for ide file path fix
  • Remove TextRangeWithHashDto as it is not what is being used by the core for Open in IDE
  • LocationDto: add codeSnippet property
  • LocationDto: change textRange property type to TextRangeDto
  • Fix LocationDto.ideFilePath property name
  • OpenInIdeHandlerImplementation: add initial Open in IDE request validation
  • OpenInIdeHandlerImplementation: change error list tool window to be shown before navigating to the issue to prevent location hiding
  • ClientFileDto: replace Uri with string, as Uri is fragile when it comes to paths with whitespaces and special characters
  • ListFilesListener now exports the correct ISLCoreListener interface
  • ListFilesListener now uses file:// schema with Uri.Encode(filePath) as the location
  • ListFilesListener now appends directory separator to all roots to avoid "C:" + "file\path" -> "C:file\path" instead of expected "C:\file\path\"
  • ListFilesListener now uses Path.GetPathRoot as the root provider instead of custom logic (this allows to support UNC paths)
  • Fix ShowHotspotParams.hotspotDetails property name
  • Add datetime and threadid to RpcDebugger
  • Fix typo in DidRemoveConfigurationScopeParams.removedId
  • Fix OpenInIdeMessageBox visibility

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource changed the title Gb/open in ide fixes Open in IDE: various bug fixes May 3, 2024
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some concerns about the ListFilesListener

src/SLCore.Listeners/Implementation/ListFilesListener.cs Outdated Show resolved Hide resolved
src/SLCore.Listeners/Implementation/ListFilesListener.cs Outdated Show resolved Hide resolved
src/Core/ISolutionWorkspaceService.cs Outdated Show resolved Hide resolved
src/Infrastructure.VS/FolderWorkspaceService.cs Outdated Show resolved Hide resolved
src/Infrastructure.VS/FolderWorkspaceService.cs Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented May 6, 2024

Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource merged commit 888f76d into feature/sloop-open-in-ide-2 May 7, 2024
35 checks passed
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource deleted the gb/open-in-ide-fixes branch May 7, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants