-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open in IDE: various bug fixes #5395
Open in IDE: various bug fixes #5395
Conversation
…rSource/sonarlint-visualstudio into gb/open-in-ide-fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concerns about the ListFilesListener
src/SLCore.Listeners.UnitTests/Implementation/ListFilesListenerTests.cs
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
888f76d
into
feature/sloop-open-in-ide-2
Fixes:
SolutionWorkspaceService
&FolderWorkspaceService
: changeIEnumerable
toICollection
in file listing to prevent delaying collection enumeration due to lazinessSolutionWorkspaceService
: deduplicate files when listing solution itemsSLCoreConstantsProvider
: enable managing of the Open in IDE server by SLOOPTextRangeWithHashDto
as it is not what is being used by the core for Open in IDELocationDto
: addcodeSnippet
propertyLocationDto
: changetextRange
property type toTextRangeDto
LocationDto.ideFilePath
property nameOpenInIdeHandlerImplementation
: add initial Open in IDE request validationOpenInIdeHandlerImplementation
: change error list tool window to be shown before navigating to the issue to prevent location hidingClientFileDto
: replaceUri
withstring
, asUri
is fragile when it comes to paths with whitespaces and special charactersListFilesListener
now exports the correctISLCoreListener
interfaceListFilesListener
now usesfile://
schema withUri.Encode(filePath)
as the locationListFilesListener
now appends directory separator to all roots to avoid"C:" + "file\path"
->"C:file\path"
instead of expected"C:\file\path\"
ListFilesListener
now usesPath.GetPathRoot
as the root provider instead of custom logic (this allows to support UNC paths)ShowHotspotParams.hotspotDetails
property namedatetime
andthreadid
toRpcDebugger
DidRemoveConfigurationScopeParams.removedId
OpenInIdeMessageBox
visibility