Update config scope when binding changes #5241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
requested a review
from ugras-ergun-sonarsource
github-actions
bot
assigned ugras-ergun-sonarsource and unassigned georgii-borovinskikh-sonarsource
|
|
||
| await configurationScopeService.DidAddConfigurationScopesAsync( | ||
| new DidAddConfigurationScopesParams(new List<ConfigurationScopeDto> { configurationScopeDto })); | ||
| if (currentConfigScope != null && currentConfigScope.id == id) |
There was a problem hiding this comment.
You can simplify if condition
Suggested change
| if (currentConfigScope != null && currentConfigScope.id == id) | |
| if (currentConfigScope?.id == id) |
ugras-ergun-sonarsource
approved these changes
Feb 22, 2024
github-actions
bot
assigned georgii-borovinskikh-sonarsource and unassigned ugras-ergun-sonarsource
|
georgii-borovinskikh-sonarsource
merged commit 61fe405
into
feature/sloop-rule-meta-data
4 checks passed
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Feb 28, 2024
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Apr 3, 2024
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5240