-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ConnectionConfigurationListener #5159
Merged
ugras-ergun-sonarsource
merged 3 commits into
feature/sloop-rule-meta-data
from
ue/ConnectionConfigurationListener
Jan 23, 2024
Merged
Implement ConnectionConfigurationListener #5159
ugras-ergun-sonarsource
merged 3 commits into
feature/sloop-rule-meta-data
from
ue/ConnectionConfigurationListener
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugras-ergun-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
January 2, 2024 15:49
georgii-borovinskikh-sonarsource
approved these changes
Jan 15, 2024
{ | ||
public Task DidSynchronizeConfigurationScopesAsync(object parameters) | ||
{ | ||
return Task.CompletedTask; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we need to implement this in the future. Did you look into that?
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
ugras-ergun-sonarsource
merged commit Jan 23, 2024
4af988e
into
feature/sloop-rule-meta-data
4 checks passed
ugras-ergun-sonarsource
deleted the
ue/ConnectionConfigurationListener
branch
January 23, 2024 10:00
ugras-ergun-sonarsource
added a commit
that referenced
this pull request
Feb 28, 2024
Fixes #5158 --------- Co-authored-by: Georgii Borovinskikh <[email protected]>
ugras-ergun-sonarsource
added a commit
that referenced
this pull request
Apr 3, 2024
Fixes #5158 --------- Co-authored-by: Georgii Borovinskikh <[email protected]>
ugras-ergun-sonarsource
added a commit
that referenced
this pull request
Apr 3, 2024
Fixes #5158 --------- Co-authored-by: Georgii Borovinskikh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5158