Fix Binary Signing #5117
Merged
Fix Binary Signing #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,25 +40,13 @@ | |||
| <CallTarget Targets="ValidateCommonSigningInputs" /> | |||
| <Error Condition="@(VSIXesToSign) == '' " Text="The list of VSIXes to sign is empty." /> | |||
|
|
|||
| <!-- For info on timestamping see https://www.digicert.com/kb/code-signing/signcode-signtool-command-line.htm --> | |||
There was a problem hiding this comment.
Link is dead
|
|
||
| <Target Name="ValidateCommonSigningInputs"> |
There was a problem hiding this comment.
no need for this anymore we don't have these.
| <Error Condition=" @(AssembliesToSign) == '' " Text="The list of assemblies to sign is empty." /> | ||
| <Error Condition=" $(SIGNTOOL_PATH) == '' " Text="The location of the signtool.exe has not been set ('SIGNTOOL_PATH')" /> |
There was a problem hiding this comment.
we do not calculate signtool path anymore
| @@ -365,8 +365,8 @@ | |||
| <Message Importance="high" Text="Copying vsix from $(TargetDir)$(TargetVsixContainerName) to $(BinariesFolder)$(TargetVsixContainerName)" /> | |||
| <Copy OverwriteReadOnlyFiles="true" SourceFiles="$(TargetDir)$(TargetVsixContainerName)" DestinationFiles="$(BinariesFolder)$(TargetVsixContainerName)" /> | |||
|
|
|||
| <Message Condition=" $(SignArtifacts) != 'true' " Importance="high" Text="Skipping signing VSIXes - SignArtifacts = '$(SignArtifacts)'" /> | |||
| <CallTarget Condition=" $(SignArtifacts) == 'true' " Targets="LocateVsixSignToolAndBinaries;SignVsixes" /> | |||
| <!--<Message Condition=" $(SignArtifacts) != 'true' " Importance="high" Text="Skipping signing VSIXes - SignArtifacts = '$(SignArtifacts)'" /> | |||
There was a problem hiding this comment.
signing vsix does not work so we have removed this step but we will add it later.
| @@ -8,6 +8,7 @@ | |||
| We'd prefer to set this the shared SonarLint.VSSpecificAssemblies.props file, but | |||
| the IDE isn't picking up the setting if we do that. --> | |||
| <DefineConstants Condition="$(VSTargetVersion)=='2022'">$(DefineConstants);VS2022</DefineConstants> | |||
| <RequiresAlmAuthentication>true</RequiresAlmAuthentication> | |||
There was a problem hiding this comment.
this is the step that changed the testing failures.
ugras-ergun-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource
approved these changes
Dec 15, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5116