Add IMuteIssuesService #5068
Merged
Add IMuteIssuesService #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ugras-ergun-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
| [PartCreationPolicy(CreationPolicy.Shared)] | ||
| internal class MuteIssuesService : IMuteIssuesService | ||
| { | ||
| private readonly IConfigurationProvider configurationProvider; |
There was a problem hiding this comment.
I did the same mistake in one of my PRs, but only realized it just now - I think we shouldn't use configuration provider directly, but instead use the cached configuration from IActiveSolutionBoundTracker for performance reasons
|
|
||
| public async Task Mute(string issueKey, CancellationToken token) | ||
| { | ||
| if (!configurationProvider.GetConfiguration().Mode.IsInAConnectedMode()) |
There was a problem hiding this comment.
I suggest adding throwifnotonbackgroundthread or an explicit switch to it
There was a problem hiding this comment.
Edit: Just throwing if on UI thread should be enough
ugras-ergun-sonarsource
requested a review
from georgii-borovinskikh-sonarsource
|
Kudos, SonarCloud Quality Gate passed! |
georgii-borovinskikh-sonarsource
approved these changes
Dec 1, 2023
ugras-ergun-sonarsource
merged commit 8274e54
into
feature/mute-server-issues
7 checks passed
ugras-ergun-sonarsource
added a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5059