Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for SQ version to fill the Combobox #5031

Merged

Conversation

ugras-ergun-sonarsource
Copy link
Contributor

Fixes #5030

@ugras-ergun-sonarsource ugras-ergun-sonarsource marked this pull request as ready for review November 21, 2023 11:04
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource changed the base branch from master to feature/mute-server-issues November 21, 2023 11:39
/// </summary>
/// <returns>True if connected to SCloud or SQube 9.7 and above, False otherwise</returns>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mean to I think instead of copy paste I made cut paste by mistake.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ugras-ergun-sonarsource ugras-ergun-sonarsource merged commit 5435973 into feature/mute-server-issues Nov 23, 2023
4 checks passed
@ugras-ergun-sonarsource ugras-ergun-sonarsource deleted the ue/version-checker branch November 23, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check for SQ version to fill the Combobox.
2 participants