Add CCT severity to Vs Severity mapping #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements #4804
georgii-borovinskikh-sonarsource
requested a review
from ugras-ergun-sonarsource
georgii-borovinskikh-sonarsource
linked an issue
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -66,4 +86,14 @@ public __VSERRORCATEGORY Convert(AnalysisIssueSeverity severity) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public static class AnalysisSeverityToVsSeverityConverterExtensions | |||
There was a problem hiding this comment.
Instead of adding this as a extension method wouldn't it make more sense to add it as public method to the IAnalysisSeverityToVsSeverityConverter and make the other two private?
There was a problem hiding this comment.
I can see your point, but I would need to change all of the tests. If you think it's worth it I'll do it
There was a problem hiding this comment.
let's keep it for now but create a hardening ticket for the future.
There was a problem hiding this comment.
ugras-ergun-sonarsource
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4804