Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPHP-1617 Happy New Year 2025 #1355

Merged
merged 2 commits into from
Jan 2, 2025
Merged

SONARPHP-1617 Happy New Year 2025 #1355

merged 2 commits into from
Jan 2, 2025

Conversation

petertrr
Copy link
Contributor

@petertrr petertrr commented Jan 2, 2025 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Happy New Year 2025 SONARPHP-1617 Happy New Year 2025 Jan 2, 2025
@petertrr petertrr requested a review from GabinL21 January 2, 2025 09:56
GabinL21
GabinL21 reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@GabinL21 GabinL21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's just missing the custom rules files, I think we need to update them manually since it doesn't use spotless

@petertrr petertrr enabled auto-merge (squash) January 2, 2025 10:26
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jan 2, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@petertrr petertrr merged commit 390fe6b into master Jan 2, 2025
17 checks passed
@petertrr petertrr deleted the petertrr/ny-2025 branch January 2, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabinL21 GabinL21 GabinL21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petertrr @GabinL21