Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPHP-1582 S3330: Only raise for variable cookies #1337

Merged
merged 1 commit into from
Dec 5, 2024
Merged

SONARPHP-1582 S3330: Only raise for variable cookies #1337

merged 1 commit into from
Dec 5, 2024

Conversation

jonas-wielage-sonarsource
Copy link
Contributor

@jonas-wielage-sonarsource jonas-wielage-sonarsource commented Dec 5, 2024 •
edited by jira bot
Loading

@jonas-wielage-sonarsource jonas-wielage-sonarsource force-pushed the SONARPHP-1582 branch 2 times, most recently from 69c2d18 to f04840a Compare December 5, 2024 13:25
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Dec 5, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

GabinL21
GabinL21 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@GabinL21 GabinL21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure if we should add this exception in the RSPEC of the rule or not 🤔

@jonas-wielage-sonarsource jonas-wielage-sonarsource merged commit 8172e32 into master Dec 5, 2024
19 checks passed
@jonas-wielage-sonarsource jonas-wielage-sonarsource deleted the SONARPHP-1582 branch December 5, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabinL21 GabinL21 GabinL21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonas-wielage-sonarsource @GabinL21