SONARPHP-1567 Add Maven build system to custom rules #1320
Conversation
GabinL21
force-pushed
the
SONARPHP-1567
branch
from
0582d91 to
d27cab1
Compare
GabinL21
force-pushed
the
SONARPHP-1567
branch
from
d27cab1 to
783be8f
Compare
| @@ -17,6 +17,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| - run: | | |||
| sed -i 's/version=.*/version=${{ github.event.inputs.version }}/' gradle.properties | |||
| cd php-custom-rules-plugin/maven && mvn versions:set -DgenerateBackupPoms=false -DnewVersion=${{ github.event.inputs.version }} | |||
There was a problem hiding this comment.
Please test that it's working. You can trigger the workflow from this branch.
There was a problem hiding this comment.
It works! #1324
(I'm bumping the custom rules version to 3.40-SNAPSHOT too, missed that)
| <pluginName>PHP Custom Rules</pluginName> | ||
| <pluginClass>org.sonar.samples.php.PHPCustomRulesPlugin</pluginClass> | ||
| <sonarLintSupported>true</sonarLintSupported> | ||
| <pluginApiMinVersion>9.9</pluginApiMinVersion> |
There was a problem hiding this comment.
Why did it change from 9.13 to 9.9 from the original pom?
https://github.com/SonarSource/sonar-php/blob/3.38.0.12239/php-custom-rules/pom.xml
There was a problem hiding this comment.
It was for consistency with sonar-php-plugin, but on second thought it makes more sense to be more restrictive for the custom rules one since we don't know what APIs users will use, I'll change it back
|
SONARPHP-1567