Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARPHP-1573 Update static RSPEC files and SonarLintTest #1315

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

jonas-wielage-sonarsource
Copy link
Contributor

@jonas-wielage-sonarsource jonas-wielage-sonarsource commented Nov 13, 2024

SONARPHP-1573

Part of

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Update static RSPEC files SONARPHP-1573 Update static RSPEC files Nov 13, 2024
"integrationTestCompileOnly"(libs.jsr305)
}

val integrationTest by sourceSets.integrationTest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not sure what this is for, but I copied it from SonarText

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the build.gradle.kts again, I found the usage. I will remove it again.

Copy link
Contributor

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

"integrationTestCompileOnly"(libs.jsr305)
}

val integrationTest by sourceSets.integrationTest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be removed

Copy link

@jonas-wielage-sonarsource jonas-wielage-sonarsource changed the title SONARPHP-1573 Update static RSPEC files SONARPHP-1573 Update static RSPEC files and SonarLintTest Nov 13, 2024
@jonas-wielage-sonarsource jonas-wielage-sonarsource merged commit 91df795 into master Nov 13, 2024
18 checks passed
@jonas-wielage-sonarsource jonas-wielage-sonarsource deleted the jonas/update-static-rspec branch November 13, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants