Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPHP-1570 Symbols should be created for tree inside PropertyHooks #1314

Merged
merged 2 commits into from
Nov 13, 2024
Merged

SONARPHP-1570 Symbols should be created for tree inside PropertyHooks #1314

merged 2 commits into from
Nov 13, 2024

Conversation

jonas-wielage-sonarsource
Copy link
Contributor

@jonas-wielage-sonarsource jonas-wielage-sonarsource commented Nov 13, 2024 •
edited by jira bot
Loading

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

jonas-wielage-sonarsource
jonas-wielage-sonarsource commented Nov 13, 2024
View reviewed changes
its/plugin/tests/src/integrationTest/java/com/sonar/it/php/Tests.java
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I found another two ITS that were not running 😓
Thankfully they were green.

rudy-regazzoni-sonarsource
rudy-regazzoni-sonarsource approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonas-wielage-sonarsource jonas-wielage-sonarsource merged commit 24bb9c2 into master Nov 13, 2024
20 checks passed
@jonas-wielage-sonarsource jonas-wielage-sonarsource deleted the SONARPHP-1570 branch November 13, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource rudy-regazzoni-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonas-wielage-sonarsource @rudy-regazzoni-sonarsource