Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARPHP-1519 Migrate sonar-php build to Gradle #1294

Merged
merged 45 commits into from
Nov 4, 2024
Merged

SONARPHP-1519 Migrate sonar-php build to Gradle #1294

merged 45 commits into from
Nov 4, 2024

Conversation

GabinL21
Copy link
Contributor

@GabinL21 GabinL21 commented Oct 30, 2024 •
edited by jira bot
Loading

@GabinL21 GabinL21 requested a review from mstachniuk October 30, 2024 09:58
mstachniuk
mstachniuk reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@mstachniuk mstachniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, please see my comments

.cirrus.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build-logic/src/main/kotlin/org.sonarsource.php.artifactory-configuration.gradle.kts Outdated Show resolved Hide resolved
build-logic/src/main/kotlin/org.sonarsource.php.artifactory-configuration.gradle.kts Outdated Show resolved Hide resolved
sonar-php-plugin/build.gradle.kts Outdated Show resolved Hide resolved
sonar-php-plugin/build.gradle.kts Outdated Show resolved Hide resolved
sonar-php-plugin/build.gradle.kts Outdated Show resolved Hide resolved
sonar-php-plugin/build.gradle.kts Outdated Show resolved Hide resolved
build-logic/src/main/kotlin/org/sonarsource/php/CodeStyleConvention.kt Outdated Show resolved Hide resolved
@GabinL21 GabinL21 self-assigned this Nov 1, 2024
@GabinL21 GabinL21 requested a review from mstachniuk November 4, 2024 08:01
mstachniuk
mstachniuk requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mstachniuk mstachniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress on it. See my comments, mostly small fixes and fixing Code Coverage as a blocker for merge

.cirrus.yml Show resolved Hide resolved
.cirrus.yml Show resolved Hide resolved
.cirrus.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
php-frontend/build.gradle.kts Outdated Show resolved Hide resolved
sonar-php-plugin/build.gradle.kts Outdated Show resolved Hide resolved
php-frontend/build.gradle.kts Show resolved Hide resolved
sonar-php-plugin/build.gradle.kts Outdated Show resolved Hide resolved
sonar-php-plugin/build.gradle.kts Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 4, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
2 Fixed issues
3 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@GabinL21 GabinL21 requested a review from mstachniuk November 4, 2024 15:10
mstachniuk
mstachniuk approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mstachniuk mstachniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabinL21 GabinL21 merged commit 2646a20 into master Nov 4, 2024
24 checks passed
@GabinL21 GabinL21 deleted the SONARPHP-1519 branch November 4, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstachniuk mstachniuk mstachniuk approved these changes

Assignees

@GabinL21 GabinL21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GabinL21 @mstachniuk