Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONAR-21408 run static test in PR #410

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

jCOTINEAU
Copy link
Contributor

No description provided.

@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-21408-run-static-test-in-PR branch 3 times, most recently from d95acc5 to f589ccf Compare January 11, 2024 13:59
Copy link
Contributor

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jCOTINEAU is there a specific reason for running the static test in GH Actions rather than Cirrus?

@jCOTINEAU
Copy link
Contributor Author

@carminevassallo, comfort mostly as we already had a similar behavior for next scan with our GitHub_action, so it was very quick to implement.

This is a very small baby step in my opinion.

@carminevassallo
Copy link
Contributor

Given that we are trying to use one CI system, would that be better to spend a little bit more time but implement the step in Cirrus?

@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-21408-run-static-test-in-PR branch 5 times, most recently from 3d17fc2 to fd171ff Compare January 16, 2024 16:00
Copy link
Contributor

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring your previous change! I think we could add another small improvement that will be useful for the other tasks too. As of now, in our CI, we don't test against a specific version of k8s.

How about we add an ENV fixing the k8s version (e.g., KUBE_VERSION) that we use to execute the static tests and to create the kind cluster (in the wait_for_kind script we don't specify the k8s version)?

p.s.
I also suggest that we rename the task into "static_compatibility_test"

@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-21408-run-static-test-in-PR branch from fd171ff to a37e57d Compare January 17, 2024 09:41
@jCOTINEAU jCOTINEAU force-pushed the feature/jc/SONAR-21408-run-static-test-in-PR branch from a37e57d to 1491a3e Compare January 17, 2024 09:50
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@carminevassallo carminevassallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 💯

@jCOTINEAU jCOTINEAU merged commit f472272 into master Jan 17, 2024
8 checks passed
@jCOTINEAU jCOTINEAU deleted the feature/jc/SONAR-21408-run-static-test-in-PR branch January 17, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants