Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL-3303 address reviewer comments removing no-op apt clean #707

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jCOTINEAU
Copy link
Contributor

@jCOTINEAU jCOTINEAU commented Sep 30, 2024

As stated by docker official images maintainer, apt clean is not needed because the eclipse temurin base image uses hooks to every dpkg / apt command to clean afterward. Hence apt clean here is a no-op entry

Copy link

Copy link
Contributor

@matteo-mara-sonarsource matteo-mara-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jCOTINEAU jCOTINEAU merged commit 5070146 into master Sep 30, 2024
31 checks passed
@jCOTINEAU jCOTINEAU deleted the rel/jc/REL-3303-address-official-image-comments branch September 30, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants