Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kellyroach/swift4 #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kellyroach
Copy link

This pull request updates pods and code in the MLKit repo to Xcode 9.4.1 / Swift 4.2 .
Currently, there are a number of yellow and red compiler issues with
the MLKit-Example as checked out. E.g.:

  • Converstion to Swift 4 is available
  • Update to recommended settings
  • error: generic parameter 'ML' is not used in function signature
  • warning: redundant conformance constraint 'Self': 'Hashable'
  • error: 'Sequence' requires the types 'Span.Element' (aka 'CountableClosedRange') and '[Int]' be equivalent

Our pull request fixes these compilation issues with MLKit-Example .
We've also added an AppIcon and LaunchImage to the demo app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant