-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on Half only where obsolete #27
base: main
Are you sure you want to change the base?
Remove dependency on Half only where obsolete #27
Conversation
These changes will break anyone depending on (de)coding Half on ARM architectures.
@dabrahams I created a release to address a lot of the issues that came up due to this repo being so out of date. Please rebase on this release and update this PR accordingly |
Otherwise it gets deleted from Package.resolved
@SomeRandomiOSDev Rebasing is going to be tough. I'm just trying to get as far as making a merge work; I'm not an Xcode/carthage/cocoapods/whatever jock, so making all those parts work is a challenge for me. It's not clear whether you're willing to accept the minimum deployment targets advancing considerably in order to get |
Description
This is just #21 but with
Half
still in use on x64 Macs. I need to remove theHalf
dependency in order to run on Windows but unfortunately x64 Macs (only!) don't supportFloat16
.Fixes #29 by avoiding SomeRandomiOSDev/Half#16
Checklist
Ensure that your
pull request
has followed all the steps below:workflowtests.sh fails, but it already fails for me on your
main
branch. I'll report a separate issue.I'm already in CONTRIBUTORS.md
Proposed changes
In addition to the motivation above, see #21.