Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate Serials Over 50 characters in inventory.py #291

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

NessieCanCode
Copy link

Ensured serial numbers don't exceed 50 characters.

Preventing this error: The request failed with code 400 Bad Request: {'serial': ['Ensure this field has no more than 50 characters.']

NessieCanCode and others added 9 commits March 20, 2024 12:48
Ensured serial numbers don't exceed 50 characters.
Truncate Serials Over 50 characters in inventory.py
Fixed an issue with IPMI interfaces with a default IP of 0.0.0.0/0, which can not be assigned within netbox. 

Fixed a small typo:

(assigned_object and assigned_object_id != interface.id):
vs.
(assigned_object and assigned_object.id != interface.id):
Skips IP within 0.0.0.0/0 within network.py
@CllaudiaB
Copy link
Collaborator

CllaudiaB commented Nov 6, 2024

Hello @NessieCanCode
Thanks for your suggestions.
Is it possible to split it into several branches? To make it easier to merge please.
For the part Skip if the interface is ib0, in the configuration file you have this part: ignore_interfaces: "(dummy.*|docker.*)" that allows you to skip interfaces according to your needs, no need to do it in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants