Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hotfixes to development-milestones to master also #23

Merged
merged 5 commits into from
Feb 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions solid-watchparty/src/App.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,13 @@ import LoginPage from './pages/LoginPage';
import MenuPage from './pages/MenuPage';
import WatchPage from './pages/WatchPage';

/* config imports */
import { BASEPATH } from './config'

const router = createBrowserRouter([
{path: "/", element: <LoginPage/>},
{path: "/menu", element: <MenuPage/>},
{path: "/watch", element: <WatchPage/>},
{path: (BASEPATH + "/"), element: <LoginPage/>},
{path: (BASEPATH + "/menu"), element: <MenuPage/>},
{path: (BASEPATH + "/watch"), element: <WatchPage/>},
]);

function App() {
Expand Down
2 changes: 1 addition & 1 deletion solid-watchparty/src/config.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export const BASEPATH = '/solid-watch-party'

/* NOTE(Elias): default POD directory structure related to the watchparty */
export const ROOMS_ROOT = 'watchparties/myRooms';
export const MESSAGES_ROOT = 'watchparties/myMessages';

5 changes: 4 additions & 1 deletion solid-watchparty/src/pages/LoginPage.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ import { useLocation } from 'react-router-dom';
import SWPageWrapper from '../components/SWPageWrapper'
import SWLoginButton from '../components/SWLoginButton'

/* config imports */
import { BASEPATH } from '../config.js'

const authOptions = {
clientName: "solid-watchparty",
};
Expand All @@ -14,7 +17,7 @@ export default function LoginPage()
{
const [oidcIssuer, setOidcIssuer] = useState("http://localhost:3000/");
const currentLocation = useLocation();
const redirectLocation = (currentLocation.state?.from || "/menu");
const redirectLocation = (currentLocation.state?.from || `${BASEPATH}/menu`);
return (
<SWPageWrapper className="flex justify-center items-center" mustBeAuthenticated={false}>
<div className="w-1/2">
Expand Down
2 changes: 1 addition & 1 deletion solid-watchparty/vite.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import react from '@vitejs/plugin-react'
// https://vitejs.dev/config/
export default defineConfig({
plugins: [react()],
base: './',
base: '/solid-watch-party/',
build: {
outDir: '../dist'
},
Expand Down
Loading