refactor: resolve warnings #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2023
Merged
Cactus-15-49
approved these changes
Aug 17, 2023
sleepdefic1t
pushed a commit
that referenced
this pull request
May 10, 2024
chore: merge upstream 1.1.3 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nano SDKs from LedgerHQ recently deprecated several functions.
This was revealed during recent unrelated updates and resulted in a static analysis CI workflow failure.
This PR proposes using LedgerHQ's newest
_no_throwfunctions and getting rid of the related try-catch patterns.more info:
Please note that the functional test workflow also fails as a result of recent external changes.
This is addressed in a separate PR (#5).