Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make probes configurable #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karlderkaefer
Copy link

this change gives the user the option to overwrite values for probes for example

helm template . --set probes.readiness.timeout=5s -s templates/solaceStatefulSet.yaml | grep -A 6 "readinessProbe:"
        readinessProbe:
          exec:
            command:
            - /mnt/disks/solace/readiness_check.sh
          initialDelaySeconds: 30
          periodSeconds: 5
          timeout: 5s

closes #137

@karlderkaefer
Copy link
Author

@bczoma could you take a look?

@bczoma
Copy link
Collaborator

bczoma commented Mar 1, 2024

@karlderkaefer thanks for the proposal. Solace is adding this to the list of upcoming features and will include it in a release, together with documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Readiness Probe configurable
2 participants