Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #47

Merged
merged 10 commits into from
Feb 5, 2024
Merged

Documentation #47

merged 10 commits into from
Feb 5, 2024

Conversation

SravanThotakura05
Copy link
Collaborator

No description provided.

@SravanThotakura05 SravanThotakura05 linked an issue Jan 31, 2024 that may be closed by this pull request
@SravanThotakura05 SravanThotakura05 self-assigned this Jan 31, 2024
Copy link
Collaborator

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've added just a couple of remarks.

docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Show resolved Hide resolved
docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved
@SravanThotakura05
Copy link
Collaborator Author

SravanThotakura05 commented Feb 5, 2024

@ozangunalp all comments are addressed and added partition key reference in documentation - https://github.com/SolaceLabs/solace-quarkus/pull/47/files

@SravanThotakura05 SravanThotakura05 marked this pull request as ready for review February 5, 2024 08:08
@SravanThotakura05 SravanThotakura05 merged commit d86ea3f into main Feb 5, 2024
3 checks passed
@SravanThotakura05 SravanThotakura05 deleted the documentation branch February 7, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete the documentation page
2 participants