Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Tests #28

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Performance Tests #28

merged 2 commits into from
Jan 22, 2024

Conversation

SravanThotakura05
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I see that there is still a direct consumer created in the incoming channel:

https://github.com/SolaceCoEExt/solace-quarkus/blob/cd0c5441e518e2e138c28c05e70c52b14fdf9405/pubsub-plus-connector/src/main/java/io/quarkiverse/solace/incoming/SolaceIncomingChannel.java#L66

I wonder what we need to change in the consumer channel when we enable support for partitioned queues.

@ozangunalp
Copy link
Collaborator

Also, we may add a test case where the long-running processing is offloaded to a worker thread using @Blocking.

@SravanThotakura05
Copy link
Collaborator Author

Hi @ozangunalp - Blocking processor test and also removed duplicate entry in pom.xml.

Changes available in this commit - ec3369d

@SravanThotakura05
Copy link
Collaborator Author

Hi @ozangunalp do you have any further comments on latest commit or we are good to merge this pull request?

Copy link
Collaborator

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozangunalp ozangunalp merged commit c348e75 into main Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants