fix: fix buildSortBy issue when sort is undefined #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dziraf
commented
Feb 12, 2024
| @@ -35,6 +37,7 @@ export class Resource extends BaseResource { | |||
| this.enums = getEnums(clientModule); | |||
| this.manager = this.client[lowerCase(model.name)]; | |||
| this.propertiesObject = this.prepareProperties(); | |||
| this.idProperty = this.properties().find((p) => p.isId())!; | |||
There was a problem hiding this comment.
non-null assertion should be safe here... A resource without ID property wouldn't work in AdminJS anyway
dziraf
commented
Feb 12, 2024
| @@ -69,15 +72,18 @@ export class Resource extends BaseResource { | |||
|
|
|||
| public async find( | |||
| filter: Filter, | |||
| params: Record<string, any> = {}, | |||
| params: { | |||
There was a problem hiding this comment.
Copied types from BaseResource. adminjs should export a proper type for this
dziraf
commented
Feb 12, 2024
| let { sortBy: path } = sort; | ||
| const { direction = 'desc' } = sort; | ||
|
|
||
| if (!path) path = this.idProperty.path(); |
There was a problem hiding this comment.
Sort by id column if nothing to sort by is specified
|
🎉 This PR is included in version 5.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.