VIS 6783 Add short Frame3f constructor #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,6 +69,12 @@ public Frame3f(Vector3f origin, Vector3f x, Vector3f y, Vector3f z) | |||
| this.rotation = m.ToQuaternion(); | |||
| } | |||
|
|
|||
| public Frame3f(double x, double y, double z, double rx, double ry, double rz, double rw) | |||
There was a problem hiding this comment.
Since you cast double to float either way, wouldn't it be easier to just accept floats in constructor?
There was a problem hiding this comment.
Sadly, I usually use double, and, then, to call it, I would need to write new Frame3f((float)0.5, ...) or new Frame3f(0.5f, ...). Both are waste of time
DmitryBubelnikSoftSmile
approved these changes
Jul 12, 2024
myroslav-valovyi
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sometimes I need to save frame3 and then create it in the test to repeat a case
The default constructor creates too many symbols if you call it often
Solution
Create as short a constructor as possible, with 7 double arguments.
Also, the ToString method is not comfortable for copying to the constructor, so I added a new one