VIS-6891 Fix ReadAsync for NetworkStream #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| using var memoryStream = new MemoryStream(buffer); | ||
| using var memoryStream = new MemoryStream(capacity: (int)stream.Length); | ||
| // 81_920 is a default value for the buffer size | ||
| await stream.CopyToAsync(memoryStream, 81_920, cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
зачем явно задавать это значение, если оно равно дефолтному?
может вызывать stream.CopyToAsync(memoryStream) ?
There was a problem hiding this comment.
Нужно передать cancellationToken, и там нет сигнатуры без передачи buffer size, но с токеном
dmitry-garshin
approved these changes
Apr 27, 2024
DmitryBubelnikSoftSmile
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ReadAsync may read less data than expected if a buffer hasn't been filled yet.
Happens when the stream is a network stream
Solution
We can simply use CopyAsync there