Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples from /sofiaLeg/sofiaComplete/ are broken #139

Open
epernod opened this issue Aug 29, 2024 · 0 comments
Open

Examples from /sofiaLeg/sofiaComplete/ are broken #139

epernod opened this issue Aug 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@epernod
Copy link
Collaborator

epernod commented Aug 29, 2024

To clean the ci I tried to fix the scenes below but didn't succeed:

  • softRobots/sofiaLeg/sofiaComplete/sofiaSixLegs.py
  • softRobots/sofiaLeg/sofiaComplete/DemoSofia.py (which in fact is just using sofiaSixLegs.py)

I already fixed several issues in #138 but there was still some problem, which required more knowledge of the modelling of that robot.
Especially regarding the call of:

leg , myController =    addSofia(sofia,
                                        name=name+str(i),
                                        rotation=rotation,
                                        translation=legPosition[i],
                                        scale=scale,
                                        surfaceColor=[0.0, 0.0, 1, 0.5],
                                        controller=actuatorArg[i],
                                        surfaceMeshFileName=surfaceMeshFileName)

refering to either SofiaLeg or Reduced_SofiaLeg which seems to have change (not the same parameters and returns)


As soon as those scene are fixed, they can be restore on the ci tests by removing the lines:

ignore "softRobots/sofiaLeg/sofiaComplete/sofiaSixLegs.py" # TODO fix: many errors in the scripts, methods signature changed, SOFA scene using old SofaPython API
ignore "softRobots/sofiaLeg/sofiaComplete/DemoSofia.py" # TODO fix: depends on sofiaSixLegs.py . Should be fixed if sofiaSixLegs.py is working

in https://github.com/SofaDefrost/ModelOrderReduction/blob/master/examples/.scene-tests

@epernod epernod added the bug Something isn't working label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant