Skip to content

Commit

Permalink
fix: chart + gh support only node20
Browse files Browse the repository at this point in the history
  • Loading branch information
devthejo committed Dec 16, 2024
1 parent f87c55c commit 16f9c36
Show file tree
Hide file tree
Showing 6 changed files with 51 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22
20
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ outputs:
description: 'GitHub App installation ID'

runs:
using: 'node22'
using: 'node20'
main: 'action/index.js'
24 changes: 20 additions & 4 deletions charts/token-bureau/templates/deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.existingSecret -}}
{{- if .Values.existingSecret }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down Expand Up @@ -38,6 +38,22 @@ spec:
- name: http
containerPort: 3000
protocol: TCP
livenessProbe:
httpGet:
path: /health
port: http
initialDelaySeconds: {{ .Values.probes.liveness.initialDelaySeconds }}
periodSeconds: {{ .Values.probes.liveness.periodSeconds }}
timeoutSeconds: {{ .Values.probes.liveness.timeoutSeconds }}
failureThreshold: {{ .Values.probes.liveness.failureThreshold }}
readinessProbe:
httpGet:
path: /health
port: http
initialDelaySeconds: {{ .Values.probes.readiness.initialDelaySeconds }}
periodSeconds: {{ .Values.probes.readiness.periodSeconds }}
timeoutSeconds: {{ .Values.probes.readiness.timeoutSeconds }}
failureThreshold: {{ .Values.probes.readiness.failureThreshold }}
envFrom:
- secretRef:
name: {{ .Values.existingSecret }}
Expand All @@ -55,6 +71,6 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- else -}}
{{- fail "You must provide an existing secret name in .Values.existingSecret" -}}
{{- end -}}
{{- else }}
{{- fail "You must provide an existing secret name in .Values.existingSecret" }}
{{- end }}
12 changes: 12 additions & 0 deletions charts/token-bureau/templates/serviceaccount.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{{- if and .Values.existingSecret .Values.serviceAccount.create -}}
apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ include "token-bureau.serviceAccountName" . }}
labels:
{{- include "token-bureau.labels" . | nindent 4 }}
{{- with .Values.serviceAccount.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
{{- end }}
12 changes: 12 additions & 0 deletions charts/token-bureau/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,18 @@ ingress:
pathType: ImplementationSpecific
tls: []

probes:
liveness:
initialDelaySeconds: 10
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 3
readiness:
initialDelaySeconds: 5
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 3

resources:
limits:
cpu: 200m
Expand Down
12 changes: 5 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,12 @@
"nodemon": "^3.1.9"
},
"engines": {
"node": ">=22.0.0"
"node": ">=20.0.0"
},
"commit-and-tag-version": {
"bumpFiles": [
{
"filename": "package.json",
"type": "json"
}
]
"bumpFiles": [{
"filename": "package.json",
"type": "json"
}]
}
}

0 comments on commit 16f9c36

Please sign in to comment.