Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: site map generator #110

Merged
merged 6 commits into from
Dec 28, 2023
Merged

feat: site map generator #110

merged 6 commits into from
Dec 28, 2023

Conversation

YoanRos
Copy link
Contributor

@YoanRos YoanRos commented Dec 28, 2023

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

nicobret
nicobret reviewed Dec 28, 2023
View reviewed changes
Copy link

@nicobret nicobret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je vois que tu utilises getStaticProps. ça veut dire que la sitemap est générée au moment du build. Qu'est-ce qui est prévu pour mettre à jour au moment de l'ajout d'un post ?
Sur un cas d'usage équivalent (sitemap d'un blog) j'ai utilisé ça : https://nextjs.org/docs/pages/building-your-application/data-fetching/incremental-static-regeneration
= ça signale au moment de l'envoi du post qu'il faut reconstruire les pages qui dépendent des données de blog (la sitemap en l'occurrence).
Ou pas besoin ici ? (si les posts sont assez rares ça ne vaut pas forcément le coup).
Sinon ça a l'air de bien fonctionner, GG.

pages/site-map.xml.js Show resolved Hide resolved
@socket-security Socket Security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
date-fns 3.0.6 None +0 4.85 MB kossnocorp
fs-extra 11.2.0 None +3 112 kB ryanzim

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
7.7% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

🎉 Deployment for commit 5d28d9c :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/ozensemble/ozensemble-site/app:sha-5d28d9cbb6789b58f193218cbe3e1c60ae214d58
Debug

@YoanRos YoanRos merged commit 4e7a3ac into master Dec 28, 2023
6 checks passed
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicobret nicobret nicobret left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YoanRos @SocialGroovyBot @nicobret