-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new package name com.androidfabrique #1811
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
🎉 Deployment for commit 3e4a666 : IngressesDocker images
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est bon pour moi avec une question
@@ -19,7 +19,7 @@ const publishAppToLatestTag = async () => { | |||
console.log(chalk.green('Success uploading app:'), chalk.green(result.stdout)); | |||
} | |||
|
|||
console.log(chalk.yellow('Transfer completed 😬: https://mano-app.fabrique.social.gouv.fr/download')); | |||
console.log(chalk.yellow('Transfer completed 😬: https://mano-app.fabrique.social.gouv.fr/download-com.manofabrique')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai pas compris pourquoi le lien change ici
le problème c'est que les gens font se retrouver avec une app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NE JAMAIS MERGER
[DISCLAIMER]
Avec le code présent, qu'il faut rebase sur main à chaque deploy de l'app, on édite une app mano avec l'identifier
com.manofabrique
au lieu decom.mano
Problème à résoudre:
Cette application est comme mano: pas sur les stores.
Mais du coup ça clash avec celle-là.
Donc avec le code présent, qu'il faut rebase sur main à chaque deploy de l'app, on édite une app mano avec l'identifier
com.manofabrique
au lieu decom.mano