Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api,dashboard): déconnecte avant de changer un mot de passe #1726

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix(api,dashboard): déconnecte avant de changer un mot de passe #1726

merged 1 commit into from
Oct 17, 2023

Conversation

arnaudambro
Copy link
Contributor

No description provided.

@arnaudambro arnaudambro temporarily deployed to review-auto October 16, 2023 15:06 — with GitHub Actions Inactive
arnaudambro
arnaudambro commented Oct 16, 2023
View reviewed changes
api/src/controllers/user.js
@@ -282,7 +282,6 @@ router.post(
const {
body: { token, password, name },
} = req;
console.log(req.body);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arnaudambro
Copy link
Contributor Author

Logout avant de MAJ un mot de passe via un lien

@github-actions
Copy link

🎉 Deployment for commit 947d2a5 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/mano/mano/api:sha-947d2a59270bdbfc0f2bcdc8253eb3affbfd58b3
  • 📦 docker pull harbor.fabrique.social.gouv.fr/mano/mano/dashboard:sha-947d2a59270bdbfc0f2bcdc8253eb3affbfd58b3
  • 📦 docker pull harbor.fabrique.social.gouv.fr/mano/mano/www:sha-947d2a59270bdbfc0f2bcdc8253eb3affbfd58b3
Debug

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@arnaudambro
Copy link
Contributor Author

je pense que ça n'a pas trop d'importance d'avoir une double review ici - au pire si tu changes d'avis on revert @rap2hpoutre
je merge !

@arnaudambro arnaudambro merged commit 435a896 into main Oct 17, 2023
10 checks passed
@arnaudambro arnaudambro deleted the fix/logout-for-reset-password branch October 17, 2023 19:09
SocialGroovyBot added a commit that referenced this pull request Oct 17, 2023
@SocialGroovyBot
chore(release): version 1.289.15
ad5a792 
## [1.289.15](v1.289.14...v1.289.15) (2023-10-17)

### Bug Fixes

* **api:** impossible de supprimer une équipe si des utilisateurs n'ont que cette équipe ([#1725](#1725)) ([db4e4b9](db4e4b9))
* **api,dashboard:** déconnecte avant de changer un mot de passe ([#1726](#1726)) ([435a896](435a896))
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 1.289.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rap2hpoutre rap2hpoutre Awaiting requested review from rap2hpoutre

Assignees

@rap2hpoutre rap2hpoutre

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnaudambro @SocialGroovyBot @rap2hpoutre