fix(dashboard): perf on merged items

SocialGouv · Sep 27, 2023 · 98c1d3a · 98c1d3a
1 parent 4e72227
commit 98c1d3a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/dashboard/src/components/DataLoader.js b/dashboard/src/components/DataLoader.js
@@ -468,8 +468,11 @@ export function useDataLoader(options = { refreshOnMount: false }) {
 }
 
 export const mergeItems = (oldItems, newItems = []) => {
-  const newItemsIds = newItems?.map((i) => i._id) || [];
-  const oldItemsPurged = oldItems.filter((i) => !newItemsIds.includes(i._id));
+  const newItemIds = {};
+  for (const newItem of newItems) {
+    newItemIds[newItem._id] = true;
+  }
+  const oldItemsPurged = oldItems.filter((i) => !newItemIds[i._id]);
   return [...oldItemsPurged, ...newItems].filter((e) => !e.deletedAt);
 };