Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contributions): afficher une hierarchie des headings valides même si un sous-titre est utilisé alors que pas de titre avant #6370

Merged
merged 12 commits into from
Dec 18, 2024

Conversation

carolineBda
Copy link
Contributor

@carolineBda carolineBda commented Dec 17, 2024

j'ai runné les tests html-validate sur les urls qui sont cassé actuellement : https://github.com/SocialGouv/code-du-travail-numerique/actions/runs/12375152517/job/34539812442?pr=6370

… si un sous-titre est utilisé alors que pas de titre avant
@carolineBda carolineBda requested review from maxgfr, m-maillot and Viczei and removed request for maxgfr December 17, 2024 16:17
titleLevel={4}
></DisplayContentContribution>
);

expect(baseElement.firstChild).toMatchSnapshot();
expect(getByText("Ceci est un titre").tagName).toEqual("H4");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai retiré les snapshot pour ne tester que ce qui nous interesse

@m-maillot m-maillot merged commit f72703d into dev Dec 18, 2024
23 checks passed
@m-maillot m-maillot deleted the carolineBda/headings-level-contribs branch December 18, 2024 14:05
@maxgfr maxgfr removed their request for review December 19, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants