-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(contributions): afficher une hierarchie des headings valides même si un sous-titre est utilisé alors que pas de titre avant #6370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… si un sous-titre est utilisé alors que pas de titre avant
carolineBda
had a problem deploying
to
review-auto
December 17, 2024 11:10 — with
GitHub Actions
Error
carolineBda
temporarily deployed
to
review-auto
December 17, 2024 11:13 — with
GitHub Actions
Inactive
carolineBda
temporarily deployed
to
review-auto
December 17, 2024 12:17 — with
GitHub Actions
Inactive
carolineBda
temporarily deployed
to
review-auto
December 17, 2024 12:34 — with
GitHub Actions
Inactive
carolineBda
temporarily deployed
to
review-auto
December 17, 2024 13:04 — with
GitHub Actions
Inactive
carolineBda
temporarily deployed
to
review-auto
December 17, 2024 13:34 — with
GitHub Actions
Inactive
carolineBda
temporarily deployed
to
review-auto
December 17, 2024 14:08 — with
GitHub Actions
Inactive
carolineBda
temporarily deployed
to
review-auto
December 17, 2024 14:32 — with
GitHub Actions
Inactive
carolineBda
had a problem deploying
to
review-auto
December 17, 2024 16:16 — with
GitHub Actions
Error
carolineBda
requested review from
maxgfr,
m-maillot and
Viczei
and removed request for
maxgfr
December 17, 2024 16:17
carolineBda
temporarily deployed
to
review-auto
December 17, 2024 16:19 — with
GitHub Actions
Inactive
carolineBda
commented
Dec 17, 2024
titleLevel={4} | ||
></DisplayContentContribution> | ||
); | ||
|
||
expect(baseElement.firstChild).toMatchSnapshot(); | ||
expect(getByText("Ceci est un titre").tagName).toEqual("H4"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j'ai retiré les snapshot pour ne tester que ce qui nous interesse
🎉 Deployment for commit 815dd1b : IngressesDocker images
|
Viczei
approved these changes
Dec 18, 2024
m-maillot
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
j'ai runné les tests html-validate sur les urls qui sont cassé actuellement : https://github.com/SocialGouv/code-du-travail-numerique/actions/runs/12375152517/job/34539812442?pr=6370