fix: rgaa fix sur l'input contact page besoin plus info #6361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viczei
commented
Dec 12, 2024
| @@ -72,6 +93,8 @@ export const BesoinPlusInformations = () => { | |||
| onSearchInput(); | |||
| } | |||
| }, | |||
| "aria-invalid": hasSearched && !result ? true : undefined, | |||
There was a problem hiding this comment.
Il pourrait être intéressant de proposer à react dsfr d'intégrer ca nativement
Viczei
commented
Dec 12, 2024
packages/code-du-travail-frontend/cypress/integration/light/outils/brut-net.spec.ts
Outdated
Show resolved
Hide resolved
Viczei
commented
Dec 12, 2024
| @@ -33,12 +35,20 @@ export const BesoinPlusInformations = () => { | |||
| emitTrackNumber(); | |||
| }; | |||
|
|
|||
| useEffect(() => { | |||
| if (hasSearched && !result) { | |||
| inputRef?.focus(); | |||
There was a problem hiding this comment.
ca c'est pour focus l'input lorsqu'il y a une erreur
Viczei
commented
Dec 12, 2024
| }, [hasSearched, result]); | ||
|
|
||
| useEffect(() => { | ||
| linkRef?.focus(); |
There was a problem hiding this comment.
celui ci pour focus le lien
maxgfr
approved these changes
Dec 12, 2024
packages/code-du-travail-frontend/src/modules/besoin-plus-informations/index.tsx
Outdated
Show resolved
Hide resolved
carolineBda
previously requested changes
Dec 16, 2024
packages/code-du-travail-frontend/cypress/integration/light/outils/brut-net.spec.ts
Outdated
Show resolved
Hide resolved
…-recherche-non-accessible
|
🎉 Deployment for commit aa993e7 : IngressesDocker images
|
m-maillot
approved these changes
Dec 19, 2024
Viczei
deleted the
6295-modale-service-près-de-moi-formulaire-de-recherche-non-accessible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.