Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(information): utilisation de tiptap sur les pages infos #1515

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

m-maillot
Copy link
Contributor

No description provided.

Copy link

socket-security bot commented Dec 12, 2024

Report too large to display inline

View full report↗︎

@m-maillot m-maillot force-pushed the linked/feat/migrate-tiptap-information branch from 2cc7048 to d72f80a Compare December 17, 2024 13:39
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
99.5% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

Copy link

🎉 Deployment for commit d72f80a :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/export:sha-d72f80a4ae06be84cc4f43f852e77dcbbea5dcd9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/frontend:sha-d72f80a4ae06be84cc4f43f852e77dcbbea5dcd9
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/cdtn-admin/hasura:sha-d72f80a4ae06be84cc4f43f852e77dcbbea5dcd9
Debug

Copy link
Contributor

@carolineBda carolineBda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo ! top tout ce clean 😍

@m-maillot m-maillot requested review from Viczei and maxgfr December 17, 2024 15:31
Copy link
Member

@maxgfr maxgfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG, ça fait plaisir qu'on est plus beosin de toutes ces libs.

Ma question, c'est comment t'as pu vérifier que la migration a pas fait péter une des 35 pages infos ?

Peux tu ré-expliquer la manière dont tu as process cela stp ?

Comment on lines -46 to -50
"rehype-raw": "^5.1.0",
"rehype-stringify": "^8.0.0",
"remark-parse": "^9.0.0",
"remark-rehype": "^8.1.0",
"unified": "^9.2.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceeeeeeeeeeeeeeeee

Comment on lines -28 to -37
export async function addGlossaryContentToMarkdown(
glossary: Glossary,
markdown?: string | null
): Promise<string> {
if (!markdown) return "";

const content = (await markdownProcessor.process(markdown))
.contents as string;
return addGlossaryContent(glossary, content);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceeeeeee

@m-maillot m-maillot merged commit 0eac658 into master Dec 18, 2024
25 of 26 checks passed
@m-maillot m-maillot deleted the linked/feat/migrate-tiptap-information branch December 18, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants