Code quality

fix(alerting): urls correctes des fiches SP dans les alerts #5454

Sign in to view logs

Triggered via pull request June 11, 2024 14:52

carolineBda

synchronize #1420

carolineBda/url-fiche-sp

Status Success

Total duration 6m 21s

Artifacts –

quality.yml

on: pull_request

Lint Dockerfile

Matrix: Lint

Matrix: Test

Matrix: Type-check

Annotations

10 errors and 68 warnings

Lint Dockerfile: targets/alert-cli/Dockerfile#L3

DL3026 error: Use only an allowed registry in the FROM image

Lint Dockerfile: targets/alert-cli/Dockerfile#L35

DL3026 error: Use only an allowed registry in the FROM image

Lint Dockerfile: targets/alert-cli/Dockerfile#L38

DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`

Lint Dockerfile: targets/export-elasticsearch/Dockerfile#L3

DL3026 error: Use only an allowed registry in the FROM image

Lint Dockerfile: targets/export-elasticsearch/Dockerfile#L5

DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`

Lint Dockerfile: targets/export-elasticsearch/Dockerfile#L5

DL3019 info: Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages

Lint Dockerfile: targets/export-elasticsearch/Dockerfile#L35

DL3026 error: Use only an allowed registry in the FROM image

Lint Dockerfile: targets/frontend/Dockerfile#L3

DL3026 error: Use only an allowed registry in the FROM image

Lint Dockerfile: targets/frontend/Dockerfile#L39

DL3026 error: Use only an allowed registry in the FROM image

Lint Dockerfile: targets/hasura/Dockerfile#L1

DL3026 error: Use only an allowed registry in the FROM image

Lint Dockerfile

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Lint Dockerfile

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Lint (@socialgouv/cdtn-elasticsearch)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Lint (@socialgouv/cdtn-elasticsearch)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Type-check (@shared/utils)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Type-check (@shared/utils)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Lint (alert-cli)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Lint (alert-cli)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Lint (alert-cli): targets/alert-cli/src/dares/difference.ts#L29

Unexpected any. Specify a different type

Lint (alert-cli): targets/alert-cli/src/dares/scrapping.ts#L10

Unsafe argument of type `any` assigned to a parameter of type `string`

Lint (alert-cli): targets/alert-cli/src/dares/scrapping.ts#L18

Unsafe argument of type `any` assigned to a parameter of type `string`

Lint (alert-cli): targets/alert-cli/src/diff/dila/__tests__/RelevantDocumentsExtractorStub.ts#L8

'modified' is defined but never used

Lint (alert-cli): targets/alert-cli/src/diff/dila/__tests__/RelevantDocumentsExtractorStub.ts#L9

'removed' is defined but never used

Lint (alert-cli): targets/alert-cli/src/diff/dila/extractReferences/__tests__/editorialContents.test.ts#L6

Unsafe return of an `any` typed value

Lint (alert-cli): targets/alert-cli/src/diff/dila/extractReferences/__tests__/editorialContents.test.ts#L23

Unsafe argument of type `any` assigned to a parameter of type `EditorialContentSubset[]`

Lint (alert-cli): targets/alert-cli/src/diff/dila/extractReferences/__tests__/editorialContents.test.ts#L23

Unexpected any. Specify a different type

Lint (alert-cli): targets/alert-cli/src/diff/dila/extractReferences/__tests__/mailTemplates.test.ts#L8

Unsafe return of an `any` typed value

Lint (alert-cli): targets/alert-cli/src/diff/dila/kali/types.ts#L3

Use an `interface` instead of a `type`

Test (@shared/utils)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Test (@shared/utils)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Test (export-elasticsearch)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Test (export-elasticsearch)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Test (ingester)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Test (ingester)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Test (frontend)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Test (frontend)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Lint (export-elasticsearch)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Lint (export-elasticsearch)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Lint (export-elasticsearch): targets/export-elasticsearch/src/controllers/__test__/export.test.ts#L41

'_next' is defined but never used

Lint (export-elasticsearch): targets/export-elasticsearch/src/ingester/__tests__/cdtnDocuments.test.ts#L22

Unsafe argument of type `any` assigned to a parameter of type `{ [s: string]: unknown; } | ArrayLike<unknown>`

Lint (export-elasticsearch): targets/export-elasticsearch/src/ingester/__tests__/cdtnDocuments.test.ts#L42

Unsafe argument of type `any` assigned to a parameter of type `{ [s: string]: unknown; } | ArrayLike<unknown>`

Lint (export-elasticsearch): targets/export-elasticsearch/src/ingester/__tests__/cdtnDocuments.test.ts#L48

Unexpected any. Specify a different type

Lint (export-elasticsearch): targets/export-elasticsearch/src/ingester/__tests__/cdtnDocuments.test.ts#L54

Unsafe argument of type `any[]` assigned to a parameter of type `ContributionElasticDocument[]`

Lint (export-elasticsearch): targets/export-elasticsearch/src/ingester/agreements/__tests__/generate.test.ts#L9

Do not use "@ts-ignore" because it alters compilation errors

Lint (export-elasticsearch): targets/export-elasticsearch/src/ingester/agreements/__tests__/getIdcc.test.ts#L5

Unexpected any. Specify a different type

Lint (export-elasticsearch): targets/export-elasticsearch/src/ingester/agreements/__tests__/getIdcc.test.ts#L7

Unsafe argument of type `any` assigned to a parameter of type `ContributionElasticDocument[]`

Lint (export-elasticsearch): targets/export-elasticsearch/src/ingester/agreements/__tests__/getTheme.test.ts#L5

Unexpected any. Specify a different type

Lint (export-elasticsearch): targets/export-elasticsearch/src/ingester/agreements/__tests__/getTheme.test.ts#L9

Unsafe argument of type `any` assigned to a parameter of type `ContributionElasticDocument`

Test (@socialgouv/cdtn-elasticsearch)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Test (@socialgouv/cdtn-elasticsearch)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Type-check (ingester)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Type-check (ingester)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Type-check (@socialgouv/cdtn-types)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Type-check (@socialgouv/cdtn-types)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Type-check (export-elasticsearch)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Type-check (export-elasticsearch)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Test (alert-cli)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Test (alert-cli)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Type-check (alert-cli)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Type-check (alert-cli)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Type-check (frontend)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Type-check (frontend)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Lint (frontend)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Lint (frontend)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Lint (ingester)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Lint (ingester)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Lint (ingester): targets/ingester/src/articles/kali/__tests__/indexed-article.test.ts#L25

Async arrow function has no 'await' expression

Lint (ingester): targets/ingester/src/articles/kali/agreement-articles-with-path.ts#L22

Unsafe argument of type `any` assigned to a parameter of type `Node`

Lint (ingester): targets/ingester/src/articles/kali/agreement-articles-with-path.ts#L22

Unexpected any. Specify a different type

Lint (ingester): targets/ingester/src/articles/kali/agreement-articles-with-path.ts#L29

Unsafe return of an `any` typed value

Lint (ingester): targets/ingester/src/articles/legi/load-labour-code-articles.ts#L5

Use an `interface` instead of a `type`

Lint (ingester): targets/ingester/src/articles/legi/load-labour-code-articles.ts#L32

Unsafe argument of type `any` assigned to a parameter of type `Node`

Lint (ingester): targets/ingester/src/articles/legi/load-labour-code-articles.ts#L32

Unexpected any. Specify a different type

Lint (ingester): targets/ingester/src/articles/legi/load-labour-code-articles.ts#L36

Unsafe return of an `any` typed value

Lint (ingester): targets/ingester/src/cli.ts#L144

Unsafe argument of type `any` assigned to a parameter of type `string`

Lint (ingester): targets/ingester/src/index.d.ts#L7

'LegalRef' is defined but never used