Update #42
Update #42
Conversation
| name: "{{ item }}" | ||
| state: installed | ||
| with_items: "{{ system_packages }}" | ||
| name: "{{ system_packages }}" |
There was a problem hiding this comment.
system_packages is a list so it probably should be used in a loop.
There was a problem hiding this comment.
Loops are not necessary with module package,apt etc. - you can just pass a list. It was changed in ver 2.5 of ansible (not 100% sure about version but its was changed)
There was a problem hiding this comment.
No it wasn't. package module just passes info to next module, so in case of debian-based installations it will pass everything to apt (which accepts a list), but on other platforms it might fail.
There was a problem hiding this comment.
I might be wrong but looking at it , I think it should be left as a list since squash_actions is going to be removed. Anyway tomorrow I'm going to check if this task generates "deprecated" warnings as in case of apt module.
There was a problem hiding this comment.
Seems legit and since this role officially supports only ubuntu xenial and CentOS7 then there is no use in checking edge cases like Arch Linux etc.
No description provided.