Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to own NBT crate #100

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Move to own NBT crate #100

wants to merge 6 commits into from

Conversation

Snowiiii
Copy link
Owner

What Advantages this has:

  • If a new game update releases and breaks/changes NBT System, We don't depend on other crates to update
  • We may can fix this
    pub fn encode(&self) -> Vec<u8> {
  • The NBT format does not support booleans, You have to write 1 or 0 u8 for a boolean. fastnbt just crashes when using booleans without any info. This took me 2 Days to debug when i first created the registry. I definitely want to support booleans, This will make Coding easier
  • We may can make our NBT crate faster than fastnbt

(Not fully serious)

  • Learn new things
  • Have Fun

@StripedMonkey
Copy link
Contributor

I advocate keeping this a module in pumpkin-protocol. In principle this is just a data format we should be (de)serializing to and from. We don't want to tie any structs to a nbt-specific data type if at all possible.

@Snowiiii Snowiiii marked this pull request as draft November 6, 2024 13:41
@Snowiiii Snowiiii mentioned this pull request Nov 16, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants