Merge pull request #24 from Snowflake-Labs/fix-geff-bucket-acl

Add acl only if bucketOnwerPreferred
Snowflake-Labs · Jun 21, 2023 · 70fe1b5 · 70fe1b5
2 parents 2a33a61 + 297caa5
commit 70fe1b5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/examples/complete/versions.tf b/examples/complete/versions.tf
@@ -1,5 +1,5 @@
 terraform {
-  required_version = "~> 1.4.4"
+  required_version = ">= 1.4.6"
 
   required_providers {
     aws = {

diff --git a/s3.tf b/s3.tf
@@ -11,6 +11,7 @@ resource "aws_s3_bucket_ownership_controls" "geff_bucket_ownership_controls" {
 }
 
 resource "aws_s3_bucket_acl" "geff_bucket_acl" {
+  count  = var.bucket_object_ownership_settings == "BucketOwnerPreferred" ? 1 : 0
   bucket = aws_s3_bucket.geff_bucket.id
   acl    = "private"
 

diff --git a/variables.tf b/variables.tf
@@ -46,6 +46,7 @@ variable "bucket_object_ownership_settings" {
   default     = "BucketOwnerEnforced"
 }
 
+
 data "aws_caller_identity" "current" {}
 data "aws_region" "current" {}
 data "aws_partition" "current" {}