Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Alert TTL handled column updation #74

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix Alert TTL handled column updation #74

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43cbac4
Add conditional to set TTL
sfc-gh-nlele Apr 29, 2024
f23541f
Update alert_dispatcher.js
sfc-gh-nlele Apr 29, 2024
bfdf835
Update alert_dispatcher.js
sfc-gh-nlele Apr 29, 2024
b57b645
Update alert_dispatcher.js
sfc-gh-nlele Apr 29, 2024
ac16a6a
Update alert_dispatcher.js
sfc-gh-nlele Apr 29, 2024
48f7994
Update alert_dispatcher.js
sfc-gh-nlele May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions procedures_js/alert_dispatcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ FROM (
WHERE suppressed = FALSE
AND IS_ARRAY(handler_payloads)
), LATERAL FLATTEN(input => handler_payloads)
WHERE alert_time > TIMEADD(MINUTES, -handler_ttl, CURRENT_TIMESTAMP)
AND (
WHERE (
handled_payload IS NULL
OR IS_NULL_VALUE(handled_payload)
)
Expand All @@ -81,19 +80,26 @@ return exec(GET_HANDLERS).rows.map((h) => {
const alert = JSON.stringify(h.ALERT)
const payload = JSON.stringify(h.HANDLER_PAYLOAD)
const alert_id = h.ALERT_ID
const alert_time = h.ALERT_TIME
const handler_num = h.HANDLER_NUM
const handler_ttl = h.HANDLER_TTL
const ttlExpired = new Date(alert_time).getTime() < Date.now() - handler_ttl * 60000;

const handledContional = ttlExpired ? 'OBJECT_CONSTRUCT(\'success\', FALSE, \'details\', \'Alert TTL expired.\')' : '$${handler_name}(PARSE_JSON(?), PARSE_JSON(?))';
const binds = ttlExpired ? [alert_id] : [alert, payload, alert_id];

const result = exec(
`UPDATE ${results_alerts_table}
SET handled = ${results_array_set_function}(
handled,
$${handler_num},
$${handler_name}(PARSE_JSON(?), PARSE_JSON(?))
$${handledContional}
)
WHERE alert_id=?
`,
[alert, payload, alert_id]
)
binds
);


return {
alert_id,
Expand Down