Jhilgart/update readme and save functionality #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jhilgart
requested review from
sfc-gh-nsehrawat,
sfc-gh-rehuang,
sfc-gh-nlimtiaco and
sfc-gh-dasilva
as code owners
sfc-gh-jhilgart
commented
May 1, 2024
| @@ -311,7 +311,7 @@ def test_invalid_yaml_missing_quote( | |||
| with pytest.raises(ValueError) as exc_info: | |||
| validate(temp_invalid_yaml_unmatched_quote_file, account_name) | |||
|
|
|||
| expected_error_fragment = "Unable to execute query with your logical table against physical tables on Snowflake. Query = SELECT ALIAS, ZIP_CODE FROM AUTOSQL_DATASET_BIRD_V2.ADDRESS.ALIAS LIMIT 100. Error = Invalid column name 'ZIP_CODE\"'. Mismatched quotes detected." | |||
| expected_error_fragment = 'Unable to execute query with your logical table against physical tables on Snowflake. Error = Invalid column name \'ZIP_CODE"\'. Mismatched quotes detected.' | |||
There was a problem hiding this comment.
removed the query from the error message so remove here
sfc-gh-dasilva
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update save based on passed path or local dir.